Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add failed tx's to undo buffer before raising #524

Merged
merged 1 commit into from
May 16, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Add failing transactions to the undo buffer prior to raising.

Fixes a bug during coverage evaluation when an eth_call reverts.

How I did it

Move the raising logic out of TransactionReceipt.__init__ and into a private method that is called after appending to the undo buffer.

How to verify it

Run tests.

@codecov-io
Copy link

codecov-io commented May 16, 2020

Codecov Report

Merging #524 into master will decrease coverage by 0.03%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   88.51%   88.47%   -0.04%     
==========================================
  Files          56       56              
  Lines        6208     6213       +5     
  Branches     1373     1373              
==========================================
+ Hits         5495     5497       +2     
- Misses        489      491       +2     
- Partials      224      225       +1     
Impacted Files Coverage Δ
brownie/network/transaction.py 86.95% <63.63%> (-0.57%) ⬇️
brownie/network/account.py 93.42% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2811d43...05799fc. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit 4cc215f into master May 16, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-tx-raising branch May 16, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants