feat: add support for EIP-712 message signing #1097
Merged
+86
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a dependency for the
eip712
package and uses it to implement a newLocalAccount.sign_message
method.What I did
Related issue: ApeWorX/eip712#4
How I did it
Added the
eip712
dependency torequirements.in
, usedpip-compile
to updaterequirements.txt
, used that new package to implement theLocalAccount.sign_message
method, wrote a new test that defines anEIP712Message
and signs it using a local account with a private key loaded, verified the test result, ran lint & other pre-commit steps, added docs, added entry in the changelog.How to verify it
I wrote a new test alongside the existing
LocalAccount
tests intest_accounts.py
Checklist