ArrowFace included in faces.py #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhcepas
reviewed
Aug 6, 2020
ete3/treeview/faces.py
Outdated
| @@ -2420,3 +2420,68 @@ def _width(self): | |||
| def _height(self): | |||
| return self.height | |||
|
|
|||
|
|
|||
| class ArrowFace(Face) | |||
There was a problem hiding this comment.
you are missing the ':'
(fix locally in your branch, then commit, then push, and the pull request will get updated automatically).
|
Done,
Should have messed it up while checking the code.
Jorge.
…On Thu, Aug 6, 2020 at 14:41, Jaime Huerta-Cepas ***@***.***> wrote:
@jhcepas commented on this pull request.
---------------------------------------------------------------
In [ete3/treeview/faces.py](#466 (comment)):
> @@ -2420,3 +2420,68 @@ def _width(self):
def _height(self):
return self.height
+
+class ArrowFace(Face)
you are missing the ':'
(fix locally in your branch, then commit, then push, and the pull request will get updated automatically).
—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub](#466 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AN7CWEAVG36GDU7V4Z2J4ELR7KQHTANCNFSM4PWRFMLQ).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.