Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor error in description of IRAFStarFinder #2

Closed
mwcraig opened this issue Jul 26, 2018 · 3 comments
Closed

Minor error in description of IRAFStarFinder #2

mwcraig opened this issue Jul 26, 2018 · 3 comments

Comments

@mwcraig
Copy link

mwcraig commented Jul 26, 2018

I was reading through the @laurenmarietta's excellent photometry notebook's and think I noticed a minor error in https://github.com/laurenmarietta/csi-stsci-notebooks/blob/photutils/photutils/02_photutils_source_detection.ipynb

In the section on IRAFStarFinder it indicates that IRAFStarFinder allows elliptical apertures but that DAOStarFinder does not. I think, based on these docs that it is the other way around; DAOStarFinder allows ellipses but IRAFStarFinder does not.

@laurenmarietta
Copy link
Contributor

Ah! Thank you so much for catching this; I mis-read the docs. I will update this now.

laurenmarietta pushed a commit to laurenmarietta/csi-stsci-notebooks that referenced this issue Jul 27, 2018
@laurenmarietta
Copy link
Contributor

@eteq could you close this issue? It has been addressed in #3.

@eteq
Copy link
Owner

eteq commented Sep 19, 2018

Thanks for the ping - done, @laurenmarietta !

@eteq eteq closed this as completed Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants