Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle cloudflare record quota better #323

Closed
meowsbits opened this issue Dec 7, 2023 · 0 comments · Fixed by etclabscore/core-geth#598
Closed

handle cloudflare record quota better #323

meowsbits opened this issue Dec 7, 2023 · 0 comments · Fixed by etclabscore/core-geth#598
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@meowsbits
Copy link
Contributor

The cloudflare record quota is 3500.

This failure #322 is caused by exceeding it (or attempting to). https://github.com/etclabscore/discv4-dns-lists/actions/runs/7127904738/job/19408807629#step:13:20

We attempted to fix it with #314 by truncating the raw list of peers to push to 3500, but that didn't work.

It didn't work because if we have 3500 records existing on CF, and want to push 3500 where some of those are new, then we'll exceed the quota because the devp2p dns to-cloudflare command will attempt to push new and updated records before deleting stale ones.

If we naively modify the deploy command to delete the stale records first, we could potentially create a negative space in the records before filling it, which could be risky if the record create/update command fails for any reason.
@meowsbits meowsbits added bug Something isn't working help wanted Extra attention is needed labels Dec 7, 2023
meowsbits added a commit to etclabscore/core-geth that referenced this issue Dec 7, 2023
@meowsbits
cmd/devp2p: avoid exceeding cloudflare record quota
3f9293c 
etclabscore/discv4-dns-lists#323

This patch modifies the deployment
pattern by deleting one stale record
before creating a new record, rather
than leaving all the stales to be deleted
at the end.

Date: 2023-12-07 08:24:07-07:00
Signed-off-by: meows <b5c6@protonmail.com>
@meowsbits meowsbits mentioned this issue Dec 7, 2023
Merged
@meowsbits meowsbits mentioned this issue Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/devp2p: avoid exceeding cloudflare record quota etclabscore/core-geth
1 participant
@meowsbits