eth: fix potential data race #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> go test -race ./eth
...
WARNING: DATA RACE
Read at 0x00000268c128 by goroutine 10750:
github.com/ethereum/go-ethereum/eth.(*chainSyncer).nextSyncOp()
/home/ia/go/src/github.com/ethereum/go-ethereum/eth/sync.go:204 +0x216
github.com/ethereum/go-ethereum/eth.(*chainSyncer).loop()
/home/ia/go/src/github.com/ethereum/go-ethereum/eth/sync.go:146 +0x3f3
github.com/ethereum/go-ethereum/eth.(*handler).Start.func3()
/home/ia/go/src/github.com/ethereum/go-ethereum/eth/handler.go:604 +0x33
Previous write at 0x00000268c128 by goroutine 8683:
github.com/ethereum/go-ethereum/eth.TestArtificialFinalityFeatureEnablingDisabling_StaleHead()
/home/ia/go/src/github.com/ethereum/go-ethereum/eth/sync_test.go:344 +0x16a
testing.tRunner()
/home/ia/go1.21.2.linux-amd64/go/src/testing/testing.go:1595 +0x238
testing.(*T).Run.func1()
/home/ia/go1.21.2.linux-amd64/go/src/testing/testing.go:1648 +0x44
Date: 2024-03-12 11:33:33-06:00
Signed-off-by: meows <b5c6@protonmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous write at 0x00000268c128 by goroutine 8683:
github.com/ethereum/go-ethereum/eth.TestArtificialFinalityFeatureEnablingDisabling_StaleHead()
/home/ia/go/src/github.com/ethereum/go-ethereum/eth/sync_test.go:344 +0x16a
testing.tRunner()
/home/ia/go1.21.2.linux-amd64/go/src/testing/testing.go:1595 +0x238
testing.(*T).Run.func1()
/home/ia/go1.21.2.linux-amd64/go/src/testing/testing.go:1648 +0x44
Date: 2024-03-12 11:33:33-06:00