Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forkid tests #580

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Forkid tests #580

merged 2 commits into from
Nov 7, 2023

Conversation

meowsbits
Copy link
Member

A small addition/fix to the GatherForks tests. Before, only block-based forks were checked. Now, also check time-based forks. Also add test cases for default networks Goerli and Sepolia.

This should have been tested already,
but was overlooked.
Tests are passing.

Date: 2023-11-02 09:37:17-06:00
Signed-off-by: meows <b5c6@protonmail.com>
Being default-availble networks,
they should have tests.

Date: 2023-11-02 09:40:23-06:00
Signed-off-by: meows <b5c6@protonmail.com>
Copy link
Member

@ziogaschr ziogaschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meowsbits meowsbits merged commit e5ae648 into master Nov 7, 2023
7 checks passed
@meowsbits meowsbits deleted the forkid-tests branch November 7, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants