Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge/foundation release/1.11 rm other client configs #535

5 changes: 4 additions & 1 deletion .github/workflows/go-generate-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ jobs:
# Intentionally revert this commit which has a custom modification to the genesis unmarshaling,
# with regards reading different genesis formats origniating from different clients
# This way, this script can alert us on any code changes that have to be applied on if file gets changed.
git revert --no-edit 4b2cf83737ffe7c46c334a11414d151de049e0b3
# This commit implements genesis JSON unmarshaling for supported data types.
git revert --no-edit 7dafb43840f8d229845b006ca8d5353f073e788c
# This commit implements omit-empty JSON marshaling for Receipt's effectiveGasPrice field.
git revert --no-edit 9024b6e494388fee55d0376e8e115e876ba42b5e

- name: Check for modified files
id: git-check
Expand Down
8 changes: 0 additions & 8 deletions cmd/echainspec/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ import (
"github.com/ethereum/go-ethereum/params/types/ctypes"
"github.com/ethereum/go-ethereum/params/types/genesisT"
"github.com/ethereum/go-ethereum/params/types/goethereum"
"github.com/ethereum/go-ethereum/params/types/multigeth"
"github.com/ethereum/go-ethereum/params/types/parity"
"gopkg.in/urfave/cli.v1"
)

Expand All @@ -26,15 +24,9 @@ var (
"coregeth": &genesisT.Genesis{
Config: &coregeth.CoreGethChainConfig{},
},
"multigeth": &genesisT.Genesis{
Config: &multigeth.ChainConfig{},
},
"geth": &genesisT.Genesis{
Config: &goethereum.ChainConfig{},
},
"parity": &parity.ParityChainSpec{},
// TODO
// "aleth"
// "retesteth"
}
)
Expand Down
3 changes: 0 additions & 3 deletions cmd/echainspec/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (

"github.com/ethereum/go-ethereum/params/types/ctypes"
"github.com/ethereum/go-ethereum/params/types/genesisT"
"github.com/ethereum/go-ethereum/params/types/parity"
"gopkg.in/urfave/cli.v1"
)

Expand Down Expand Up @@ -48,8 +47,6 @@ func unmarshalChainSpec(format string, data []byte) (conf ctypes.Configurator, e
switch t := configurator.(type) {
case *genesisT.Genesis:
d.Config = t.Config
case *parity.ParityChainSpec:
// Don't need to do anything here; the Parity type already conforms to ChainConfigurator.
default:
return nil, fmt.Errorf("unhandled chainspec type: %v %v", format, t)
}
Expand Down
5 changes: 3 additions & 2 deletions contracts/checkpointoracle/contract/oracle.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions core/types/gen_receipt_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

112 changes: 55 additions & 57 deletions eth/ethconfig/gen_config.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading