Feat/gardening 20200727 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This orders them developmentally-chronologically and puts unit tests first, with regression (integration) last. Signed-off-by: meows <b5c6@protonmail.com>
Ropsten flag was addded to supersede 'testnet', and should have a test case here. When --testnet is finally removed, the associated test case may be removed as well. Signed-off-by: meows <b5c6@protonmail.com>
'geth' is no longer an available option. This refactors to use the global chain format dictionary, unifying the app's option declaration and logic. Signed-off-by: meows <b5c6@protonmail.com>
NetworkID is allowed to be zero. Although this is an edge case in practice, occuring only on the Olympic network and in some test configurations. Signed-off-by: meows <b5c6@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-coregethcommand--ropstenflagechainspec validatelogic (used antiquated "geth" key)confp.Validateconditional testing NetworkID != 0; network id should be allowed to be 0, but not nil.