Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3.6 downgrade instructions. #965

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add 3.6 downgrade instructions. #965

wants to merge 1 commit into from

Conversation

siyuanfoundation
Copy link
Contributor

@ivanvc ivanvc mentioned this pull request Feb 28, 2025
Closed
@ivanvc
Copy link
Member

ivanvc commented Feb 28, 2025

Thanks for the PR, @siyuanfoundation.

The v3.6 update guide link isn't working. I opened #966 to add a layout/placeholder so we can avoid these issues.

Could you please take a look at the linter issues? https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_website/965/pull-website-lint/1895572262531108864

Thanks again :)

@ahrtr
Copy link
Member

ahrtr commented Mar 6, 2025

Could you move the downgrade_3.5 related change into a separate PR? It should can be approved & merged soon.

@fuweid can you please take a look at the downgrade_3.6 guide if you get time? thx

fuweid
fuweid reviewed Mar 6, 2025
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Just have few minior questions.
Thanks!

content/en/docs/v3.6/downgrades/downgrade_3_5.md Outdated

```diff
-etcd-old --name s1 \
+etcd-new --name s1 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about etcd-3.4-bin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

content/en/docs/v3.6/downgrades/downgrade_3_6.md Outdated

```diff
-etcd-old --name s1 \
+etcd-new --name s1 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about etcd-3.5-bin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

content/en/docs/v3.6/downgrades/downgrade_3_6.md
+-----------------+------------------+---------------+-----------------+---------+--------+-----------------------+-------+-----------+------------+-----------+------------+--------------------+--------+--------------------------+-------------------+
| ENDPOINT | ID | VERSION | STORAGE VERSION | DB SIZE | IN USE | PERCENTAGE NOT IN USE | QUOTA | IS LEADER | IS LEARNER | RAFT TERM | RAFT INDEX | RAFT APPLIED INDEX | ERRORS | DOWNGRADE TARGET VERSION | DOWNGRADE ENABLED |
+-----------------+------------------+---------------+-----------------+---------+--------+-----------------------+-------+-----------+------------+-----------+------------+--------------------+--------+--------------------------+-------------------+
| localhost:2379 | 8211f1d0f64f3269 | 3.5.18 | | 20 kB | 16 kB | 20% | 0 B | false | false | 3 | 14 | 14 | | | false |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first row with disabled maybe confusing because the DowngradeInfo isn't backported to v3.5.
I was thinking that we should highlight this information to user: it's still enabled

Copy link
Contributor Author

@siyuanfoundation siyuanfoundation Mar 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a Note.

@siyuanfoundation
Copy link
Contributor Author

siyuanfoundation commented Mar 6, 2025 •
edited
Loading

Could you move the downgrade_3.5 related change into a separate PR? It should can be approved & merged soon.

3.5 changes in #970

fuweid
fuweid approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the page.
The CI fails because of lack of index.html

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fuweid, siyuanfoundation
Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ajaysundark ajaysundark mentioned this pull request Mar 8, 2025
Open
@siyuanfoundation @ajaysundark
Add 3.6 downgrade instructions.
af87556 
Signed-off-by: Siyuan Zhang <sizhang@google.com>

Co-authored-by: ajaysundar.k <ajaysundar.k@gmail.com>
@siyuanfoundation
Copy link
Contributor Author

Thanks @ajaysundark for the careful review!

@jberkus
Copy link
Contributor

jberkus commented Mar 13, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaysundark ajaysundark ajaysundark left review comments

@fuweid fuweid fuweid approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@siyuanfoundation @ivanvc @ahrtr @k8s-ci-robot @jberkus @ajaysundark @fuweid