Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose WithCreatedNotify in WatchOption and isCreatedNotify in WatchResponse #1186

Closed
0x01F4 opened this issue Jul 7, 2023 · 2 comments · Fixed by #1187
Closed

Expose WithCreatedNotify in WatchOption and isCreatedNotify in WatchResponse #1186

0x01F4 opened this issue Jul 7, 2023 · 2 comments · Fixed by #1187

Comments

@0x01F4
Copy link
Contributor

0x01F4 commented Jul 7, 2023 •
edited
Loading

When I create a watch there is delay in watch starting and receiving events.So if I start a watch and put/delete keys in etcd I am missing events.

If I can get Created event in WatchResponse then I can wait for the event to put/delete keys in etcd.

Used Thread.sleep(1000) which seems to be working but not ideal.

Looks like WithCreatedNotify is already there in go client.
https://github.com/etcd-io/etcd/blob/bdbbde998b7ed434b23676530d10dbd601c4a7c0/client/v3/op.go#L484
@lburgazzoli
Copy link
Collaborator

can you provide a pr ?

@0x01F4 0x01F4 mentioned this issue Jul 8, 2023
Merged
@0x01F4
Copy link
Contributor Author

0x01F4 commented Jul 8, 2023

@lburgazzoli PR #1187

lburgazzoli pushed a commit that referenced this issue Jul 8, 2023
@0x01F4 @lburgazzoli
watcher: Added WithCreatedNotify Option for receiving created event
151c1d7 
This adds WatchOption to receive watch created event

Fixes #1186

Signed-off-by: Giridharan Ramasamy <46867712+giri-vsr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

watcher: Added WithCreatedNotify Option for receiving created event
2 participants
@lburgazzoli @0x01F4