*: integrate https://github.com/mgechev/revive with fmt tests #9951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/mgechev/revive Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #9951 +/- ##
==========================================
+ Coverage 69.12% 69.15% +0.03%
==========================================
Files 386 386
Lines 35784 35783 -1
==========================================
+ Hits 24735 24747 +12
- Misses 9232 9236 +4
+ Partials 1817 1800 -17
Continue to review full report at Codecov.
|
|
lgtm |
gyuho
commented
Jul 23, 2018
| @@ -216,9 +216,8 @@ func (s *store) Set(nodePath string, dir bool, value string, expireOpts TTLOptio | |||
| if getErr != nil { | |||
| err = getErr | |||
| return nil, err | |||
| } else { | |||
There was a problem hiding this comment.
@jpbetz Now this should be caught automatic :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/mgechev/revive is pretty fast adding only 5 seconds to total test runtime.
Masked some of the warnings as TODOs.