Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gopkg.*: remove directive dependencies from Gopkg.toml #9240

Merged
merged 1 commit into from
Jan 27, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jan 26, 2018

Reproducible builds are already done via Gopkg.lock.
Remove "constraint"s for external projects with conflicting
dependencies.

See related discussion #9155 (comment).

/cc @tamird @sdboyer @xiang90 @fanminshi

#9224

Reproducible builds are already done via Gopkg.lock.
Remove "constraint"s for external projects with conflicting
dependencies.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@gyuho
Copy link
Contributor Author

gyuho commented Jan 26, 2018

@xiang90

Our preferred dependency update workflow was:

  1. Update Gopkg.toml
  2. Run dep ensure

Similar to what we had with glide.

But the conflicting rules in Gopkg.toml breaks external projects that also use dep.
Now we update dependencies with dep ensure -update package-name-goes-here.

@codecov-io
Copy link

Codecov Report

Merging #9240 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9240      +/-   ##
==========================================
- Coverage   75.87%   75.85%   -0.02%     
==========================================
  Files         363      363              
  Lines       30190    30190              
==========================================
- Hits        22907    22901       -6     
- Misses       5684     5685       +1     
- Partials     1599     1604       +5
Impacted Files Coverage Δ
proxy/grpcproxy/register.go 69.44% <0%> (-13.89%) ⬇️
pkg/testutil/recorder.go 77.77% <0%> (-3.71%) ⬇️
pkg/adt/interval_tree.go 86.48% <0%> (-3.61%) ⬇️
etcdserver/api/v3election/election.go 64.7% <0%> (-2.95%) ⬇️
raft/node.go 90.62% <0%> (-1.79%) ⬇️
rafthttp/msgappv2_codec.go 69.56% <0%> (-1.74%) ⬇️
clientv3/leasing/cache.go 87.77% <0%> (-1.67%) ⬇️
etcdserver/cluster_util.go 76.64% <0%> (-1.46%) ⬇️
clientv3/leasing/kv.go 90.36% <0%> (-1%) ⬇️
etcdserver/server.go 79.63% <0%> (+0.11%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1153e43...1c5c821. Read the comment docs.

@sdboyer
Copy link

sdboyer commented Jan 27, 2018

(didn't mean to comment here, moved to #9224 (comment))

@gyuho gyuho merged commit ce0ad37 into etcd-io:master Jan 27, 2018
@gyuho gyuho deleted the vendor branch January 27, 2018 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants