-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack/scripts-dev: add "docker-dns-example-certs-common-name-run" #8961
Conversation
--endpoints=https://m1.etcd.local:2379,https://m2.etcd.local:22379,https://m3.etcd.local:32379 \ | ||
get abc | ||
|
||
sleep 1s && printf "\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no sleep?
same as many places down below/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep sleep here. I am trying to put example workflow here with print statements. Otherwise, it's hard to follow.
get abc | ||
|
||
sleep 1s && printf "\n" | ||
echo "Step 1. creating root role" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand this test.
why are we creating root user and root role?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User must create root
user and role first. It's special user and role. https://github.com/coreos/etcd/blob/master/Documentation/op-guide/authentication.md#special-users-and-roles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are testing this scenario right?https://github.com/coreos/etcd/blob/master/Documentation/op-guide/authentication.md#using-tls-common-name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
cf95d67
to
5071711
Compare
Codecov Report
@@ Coverage Diff @@
## master #8961 +/- ##
=========================================
Coverage ? 76.06%
=========================================
Files ? 359
Lines ? 29837
Branches ? 0
=========================================
Hits ? 22695
Misses ? 5570
Partials ? 1572 Continue to review full report at Codecov.
|
5071711
to
c0afdbe
Compare
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
mv ca.pem ca.crt | ||
openssl x509 -in ca.crt -noout -text | ||
|
||
# generate wildcard certificates DNS: *.etcd.local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't seems like you are generating wildcard certificates from server-ca-csr.json
"hosts": [
"m1.etcd.local",
"m2.etcd.local",
"m3.etcd.local",
"127.0.0.1",
"localhost"
]
this script is more a demo of how to use common name than a test script. suggest rename this as a demo script. |
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
c0afdbe
to
5783460
Compare
Address #8502.
Separate out from #8954.
/cc @fanminshi