hack/scripts-dev: share docker image between test cases, clean up DNS SRV tests #8959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
force-pushed
the
test-scripts-3
branch
3 times, most recently
from
20fff05
to
90c9b08
Compare
fanminshi
reviewed
Dec 1, 2017
| --discovery-srv etcd.local \ | ||
| endpoint health --cluster | ||
|
|
||
| sleep 2s |
| --discovery-srv etcd.local \ | ||
| put abc def | ||
|
|
||
| sleep 2s |
|
some nits. then lgtm |
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
…est-certs-wildcard-run Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up existing certs so that they can share the same docker image.
And address #8502.
Separate out from #8954.
/cc @fanminshi