*: upgrade gRPC v1.7.x with balancer connection drain fix #8831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
To handle new grpc error messages in v1.7.x Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
…erClose Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gRPC v1.7.x does not pass errConnDrain to balancer, so blackholed endpoint does not get unpinned until the connection is closed. So it's possible that updateNotifyLoop notifies blackholed endpoint twice before the blackholed endpoint gets unpinned and the balancer pins a new one. This keeps track of all gRPC connection Up and down, to make connection drain and "notifyAddrs" operation synchronous. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC v1.7.x does not pass errConnDrain to balancer,
so blackholed endpoint does not get unpinned until
the connection is closed. So it's possible that
updateNotifyLoop notifies blackholed endpoint twice
before the blackholed endpoint gets unpinned and the
balancer pins a new one.
This keeps track of all gRPC connection Up and down,
to make connection drain and "notifyAddrs" operation
synchronous.
Fix #8828.
Also handle new gRPC "no connection" error in retry.
DEBUGGING:
https://semaphoreci.com/coreos/etcd/branches/pull-request-8831/builds/3