Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpcproxy: forward PrevKv flag in Put #8366

Merged
merged 2 commits into from
Aug 4, 2017

Conversation

heyitsanthony
Copy link
Contributor

@codecov-io
Copy link

Codecov Report

Merging #8366 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8366      +/-   ##
==========================================
- Coverage   76.74%   76.71%   -0.04%     
==========================================
  Files         349      349              
  Lines       27366    27368       +2     
==========================================
- Hits        21003    20994       -9     
- Misses       4857     4868      +11     
  Partials     1506     1506
Impacted Files Coverage Δ
proxy/grpcproxy/kv.go 99.25% <100%> (+0.01%) ⬆️
pkg/adt/interval_tree.go 82.58% <0%> (-8.11%) ⬇️
etcdserver/api/v3rpc/watch.go 89.3% <0%> (-4.19%) ⬇️
proxy/grpcproxy/watcher.go 85.71% <0%> (-4.09%) ⬇️
pkg/transport/listener_tls.go 65.56% <0%> (-0.67%) ⬇️
etcdserver/api/v3rpc/lease.go 96.42% <0%> (ø) ⬆️
clientv3/watch.go 95.04% <0%> (ø) ⬆️
lease/leasehttp/http.go 62.59% <0%> (ø) ⬆️
etcdserver/server.go 80.2% <0%> (+0.23%) ⬆️
etcdserver/apply.go 91.09% <0%> (+0.52%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa4a62...6a4194c. Read the comment docs.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@heyitsanthony heyitsanthony merged commit 366f538 into etcd-io:master Aug 4, 2017
@heyitsanthony heyitsanthony deleted the prevkey-proxy branch August 4, 2017 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants