Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvcc: Add metric for count of db key revisions compacted. #8280

Merged
merged 1 commit into from
Jul 20, 2017

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Jul 19, 2017

When digging into etcd/boltdb "storage space exceeded" issues, this metric may help answer questions about if/when compactions occured and how much data was freed.

@jpbetz
Copy link
Contributor Author

jpbetz commented Jul 19, 2017

@heyitsanthony Here's one of the metrics that might help us in the future.

@heyitsanthony
Copy link
Contributor

would s/Revisions/Keys be better? There may be confusion between an etcd revision (mainrev) and a backend revision (mainrev + subrev).

@codecov-io
Copy link

Codecov Report

Merging #8280 into master will decrease coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8280      +/-   ##
==========================================
- Coverage   76.42%   76.23%   -0.19%     
==========================================
  Files         346      346              
  Lines       27055    27059       +4     
==========================================
- Hits        20676    20628      -48     
- Misses       4901     4940      +39     
- Partials     1478     1491      +13
Impacted Files Coverage Δ
mvcc/kvstore_compaction.go 79.41% <100%> (+1.99%) ⬆️
mvcc/metrics.go 96% <100%> (+0.16%) ⬆️
pkg/transport/timeout_conn.go 80% <0%> (-20%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-13.89%) ⬇️
auth/simple_token.go 86.79% <0%> (-6.61%) ⬇️
pkg/adt/interval_tree.go 87.38% <0%> (-3.61%) ⬇️
etcdserver/api/v3rpc/watch.go 90.14% <0%> (-3.29%) ⬇️
integration/bridge.go 89% <0%> (-3%) ⬇️
clientv3/concurrency/election.go 80% <0%> (-2.41%) ⬇️
pkg/netutil/netutil.go 62.35% <0%> (-2.36%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 608df0f...2d2c076. Read the comment docs.

@jpbetz
Copy link
Contributor Author

jpbetz commented Jul 20, 2017

@heyitsanthony s/Revisions/Keys sounds good. I'll update the PR.

When digging into etcd/boltdb "storage space exceeded" issues, this metric may help answer questions about if/when compactions occured and how much data was freed.
Copy link
Contributor

@heyitsanthony heyitsanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@xiang90
Copy link
Contributor

xiang90 commented Jul 20, 2017

lgtm

@xiang90 xiang90 merged commit fb717ae into etcd-io:master Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants