Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools/etcd-dump-logs] Fix the usage of --start-index in etcd-dump-logs #19082

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Dec 18, 2024

Currently if users explicitly set --start-index=0, it will be ignored. It isn't expected, we should respect it as long as users explicitly set it.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Currently if users explicitly set --start-index=0, it will
be ignored. It isn't expected, we should respect it as long
as users explicitly set it.

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr ahrtr changed the title Fix the usage of --start-index in etcd-dump-logs [tools/etcd-dump-logs] Fix the usage of --start-index in etcd-dump-logs Dec 18, 2024
@ahrtr
Copy link
Member Author

ahrtr commented Dec 18, 2024

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (0966b4d) to head (76f436c).
Report is 2 commits behind head on main.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19082      +/-   ##
==========================================
+ Coverage   68.71%   68.74%   +0.03%     
==========================================
  Files         420      420              
  Lines       35640    35640              
==========================================
+ Hits        24489    24500      +11     
+ Misses       9723     9708      -15     
- Partials     1428     1432       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0966b4d...76f436c. Read the comment docs.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit b531071 into etcd-io:main Dec 18, 2024
36 checks passed
@ahrtr ahrtr deleted the etcd-logs_20241218 branch December 18, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants