Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: remaining errors.Is conversions #18617

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

redwrasse
Copy link
Contributor

Remaining errors.Is conversions for server module, as part of #18576.

Signed-off-by: redwrasse <mail@redwrasse.io>
…lity checks

Signed-off-by: redwrasse <mail@redwrasse.io>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redwrasse
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @redwrasse. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 68.72%. Comparing base (6ea81c1) to head (ccd65fe).

Current head ccd65fe differs from pull request most recent head 5d242b0

Please upload reports for the commit 5d242b0 to get more accurate results.

Files with missing lines Patch % Lines
server/etcdserver/api/v2discovery/discovery.go 0.00% 1 Missing and 1 partial ⚠️
server/etcdserver/api/v3rpc/watch.go 50.00% 1 Missing and 1 partial ⚠️
server/etcdserver/api/rafthttp/snapshot_sender.go 0.00% 0 Missing and 1 partial ⚠️
server/etcdserver/api/v3rpc/lease.go 83.33% 0 Missing and 1 partial ⚠️
server/proxy/grpcproxy/lease.go 0.00% 0 Missing and 1 partial ⚠️
server/proxy/grpcproxy/maintenance.go 0.00% 1 Missing ⚠️
server/storage/wal/decoder.go 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/api/rafthttp/pipeline.go 97.40% <100.00%> (ø)
server/etcdserver/api/rafthttp/stream.go 81.81% <100.00%> (ø)
server/etcdserver/api/v3rpc/util.go 67.74% <100.00%> (ø)
server/lease/leasehttp/http.go 64.18% <100.00%> (+2.02%) ⬆️
server/etcdserver/api/rafthttp/snapshot_sender.go 84.15% <0.00%> (ø)
server/etcdserver/api/v3rpc/lease.go 77.21% <83.33%> (-5.07%) ⬇️
server/proxy/grpcproxy/lease.go 89.14% <0.00%> (ø)
server/proxy/grpcproxy/maintenance.go 39.39% <0.00%> (ø)
server/storage/wal/decoder.go 89.00% <0.00%> (ø)
server/etcdserver/api/v2discovery/discovery.go 63.31% <0.00%> (ø)
... and 1 more

... and 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18617      +/-   ##
==========================================
- Coverage   68.78%   68.72%   -0.06%     
==========================================
  Files         420      420              
  Lines       35519    35519              
==========================================
- Hits        24431    24410      -21     
- Misses       9662     9683      +21     
  Partials     1426     1426              

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ea81c1...5d242b0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants