[2024-08-29] Bump dependency updates identified by dependabot #18515

henrybear327 · 2024-08-29T20:14:34Z

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.

Summary of actions

Bumped

build(deps): bump github.com/golangci/golangci-lint from 1.59.1 to 1.60.3 in /tools/mod #18504
build(deps): bump github.com/google/btree from 1.1.2 to 1.1.3 #18500
build(deps): bump go.opentelemetry.io/otel from 1.28.0 to 1.29.0 #18499
build(deps): bump go.opentelemetry.io/otel/trace from 1.28.0 to 1.29.0 #18498
build(deps): bump go.opentelemetry.io/otel/sdk from 1.28.0 to 1.29.0 #18497
build(deps): bump github.com/prometheus/client_golang from 1.20.0 to 1.20.2 in /tools/mod #18492 + build(deps): bump github.com/prometheus/client_golang from 1.20.0 to 1.20.2 #18491

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Reference: - etcd-io#18504 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

Reference: - etcd-io#18500 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

…ump go.opentelemetry.io/otel/trace from 1.28.0 to 1.29. Reference: - etcd-io#18499 - etcd-io#18498 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

Reference: - etcd-io#18497 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

….20.2 Reference: - etcd-io#18492 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

Log: integration/metrics_test.go:139:4: SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck) t.Fatalf(err.Error()) ^ integration/clientv3/lease/lease_test.go:410:4: SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck) t.Fatalf(errMsg) Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

codecov-commenter · 2024-08-29T20:35:39Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 68.85%. Comparing base (fe796ab) to head (d82b977).
Report is 2 commits behind head on main.

❗ Current head d82b977 differs from pull request most recent head 06a6da0

Please upload reports for the commit 06a6da0 to get more accurate results.

Files with missing lines	Patch %	Lines
client/v3/kubernetes/client.go	0.00%	27 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Files with missing lines	Coverage Δ
client/v3/kubernetes/client.go	`0.00% <0.00%> (ø)`

... and 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18515      +/-   ##
==========================================
+ Coverage   68.77%   68.85%   +0.08%     
==========================================
  Files         420      420              
  Lines       35489    35470      -19     
==========================================
+ Hits        24407    24423      +16     
+ Misses       9650     9613      -37     
- Partials     1432     1434       +2

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe796ab...06a6da0. Read the comment docs.

ivanvc · 2024-08-29T21:38:30Z

@henrybear327, it looks like dependabot didn't try to update go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc to 1.29.0. I think it's because we closed #18297, as it looked indirect, but it's a direct dependency defined in server/go.mod. So, maybe along with your commit 7ef38ee, you can update that dependency too if that makes sense.

ahrtr · 2024-08-30T07:15:36Z

I think it's because we closed #18297, as it looked indirect, but it's a direct dependency defined in server/go.mod

Right. purely indirect should mean that it's a purely indirect dependency in all modules.

maybe along with your commit 7ef38ee, you can update that dependency too

+1

ahrtr · 2024-08-30T07:17:14Z

So, maybe along with your commit 7ef38ee, you can update that dependency too if that makes sense.

It's OK to address it in a separate PR, which might be a little easier. @henrybear327 Please let's know if you want to resolve it in this PR or a separate PR

ivanvc

LGTM. As @ahrtr suggested, we can bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc in a follow-up pull request. Thanks, Henry.

henrybear327 · 2024-08-30T20:55:03Z

➜  etcd git:(dependencies/08_29_24) grep -Ri "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v" | grep -v sum 
./etcdutl/go.mod:       go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.27.0 // indirect
./go.mod:       go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.27.0 // indirect
./tests/go.mod: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.27.0 // indirect
./server/go.mod:        go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.27.0

I can bump it now. Sorry for missing the discussion!

…lptracegrpc from 1.27.0 to 1.29.0 Reference: - etcd-io#18515 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

…0-20240814211410-ddb44dafa142 to v0.0.0-20240822170219-fc7c04adadcd Due to bumping go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.27.0 to 1.29.0 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

henrybear327 · 2024-08-30T21:04:20Z

LGTM. As @ahrtr suggested, we can bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc in a follow-up pull request. Thanks, Henry.

@ivanvc @ahrtr bumped the dependency as requested/spotted!

Sorry for missing out on the previous comment again.

henrybear327 · 2024-08-30T21:40:01Z

/retest

henrybear327 · 2024-08-30T22:00:32Z

/retest

ivanvc

LGTM. Thanks, Henry.

ahrtr

LGTM

Thanks

k8s-ci-robot · 2024-08-31T07:32:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, henrybear327, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…lptracegrpc from 1.27.0 to 1.29.0 Reference: - etcd-io#18515 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

henrybear327 added 5 commits August 29, 2024 22:12

dependency: bump github.com/golangci/golangci-lint from 1.59.1 to 1.60.3

bcc229a

Reference: - etcd-io#18504 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

dependency: bump github.com/google/btree from 1.1.2 to 1.1.3

f56a0a4

Reference: - etcd-io#18500 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

dependency: bump go.opentelemetry.io/otel from 1.28.0 to 1.29.0 and b…

7ef38ee

…ump go.opentelemetry.io/otel/trace from 1.28.0 to 1.29. Reference: - etcd-io#18499 - etcd-io#18498 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

dependency: bump go.opentelemetry.io/otel/sdk from 1.28.0 to 1.29.0

40fc67e

Reference: - etcd-io#18497 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

dependency: bump github.com/prometheus/client_golang from 1.20.0 to 1…

0778170

….20.2 Reference: - etcd-io#18492 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

k8s-ci-robot added area/clientv3 area/etcdctl area/etcdutl area/testing area/tooling size/L labels Aug 29, 2024

ivanvc approved these changes Aug 30, 2024

View reviewed changes

henrybear327 added 3 commits August 30, 2024 22:58

dependency: bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/ot…

c2d4f2b

…lptracegrpc from 1.27.0 to 1.29.0 Reference: - etcd-io#18515 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

henrybear327 requested a review from ivanvc August 30, 2024 21:04

ivanvc approved these changes Aug 30, 2024

View reviewed changes

ahrtr approved these changes Aug 31, 2024

View reviewed changes

k8s-ci-robot added the approved label Aug 31, 2024

ahrtr merged commit 4bb9392 into etcd-io:main Aug 31, 2024
43 checks passed

henrybear327 deleted the dependencies/08_29_24 branch September 1, 2024 14:17

a-nych pushed a commit to a-nych/etcd that referenced this pull request Oct 16, 2024

dependency: bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/ot…

90b2a24

…lptracegrpc from 1.27.0 to 1.29.0 Reference: - etcd-io#18515 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

a-nych pushed a commit to a-nych/etcd that referenced this pull request Oct 16, 2024

dependency: bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/ot…

ed4f76e

…lptracegrpc from 1.27.0 to 1.29.0 Reference: - etcd-io#18515 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[2024-08-29] Bump dependency updates identified by dependabot #18515

[2024-08-29] Bump dependency updates identified by dependabot #18515

henrybear327 commented Aug 29, 2024

codecov-commenter commented Aug 29, 2024 •

edited

Loading

ivanvc commented Aug 29, 2024

ahrtr commented Aug 30, 2024

ahrtr commented Aug 30, 2024

ivanvc left a comment

henrybear327 commented Aug 30, 2024

henrybear327 commented Aug 30, 2024

henrybear327 commented Aug 30, 2024

henrybear327 commented Aug 30, 2024

ivanvc left a comment

ahrtr left a comment

k8s-ci-robot commented Aug 31, 2024

[2024-08-29] Bump dependency updates identified by dependabot #18515

[2024-08-29] Bump dependency updates identified by dependabot #18515

Conversation

henrybear327 commented Aug 29, 2024

codecov-commenter commented Aug 29, 2024 • edited Loading

Codecov Report

ivanvc commented Aug 29, 2024

ahrtr commented Aug 30, 2024

ahrtr commented Aug 30, 2024

ivanvc left a comment

Choose a reason for hiding this comment

henrybear327 commented Aug 30, 2024

henrybear327 commented Aug 30, 2024

henrybear327 commented Aug 30, 2024

henrybear327 commented Aug 30, 2024

ivanvc left a comment

Choose a reason for hiding this comment

ahrtr left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Aug 31, 2024

codecov-commenter commented Aug 29, 2024 •

edited

Loading