Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.4] *: keep tombstone if revision == compactAtRev #18475

Merged
merged 2 commits into from
Aug 21, 2024
Merged

[3.4] *: keep tombstone if revision == compactAtRev #18475

merged 2 commits into from
Aug 21, 2024

Commits on Aug 20, 2024

  1. *: update tests for watch API when compact on tombstone revision 

    Signed-off-by: Wei Fu <fuweid89@gmail.com>
(cherry picked from commit ee33652)
Signed-off-by: Wei Fu <fuweid89@gmail.com>
    @fuweid
    fuweid committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4b7c1f4 View commit details
    Browse the repository at this point in the history

  2. *: keep tombstone if revision == compactAtRev 

    Before this patch, the tombstone can be deleted if its revision is equal
compacted revision. It causes that the watch subscriber won't get this
DELETE event. Based on Compact API[1], we should keep tombstone revision
if it's not less than the compaction revision.

> CompactionRequest compacts the key-value store up to a given revision.
> All superseded keys with a revision less than the compaction revision
> will be removed.

[1]: https://etcd.io/docs/latest/dev-guide/api_reference_v3/

Signed-off-by: Wei Fu <fuweid89@gmail.com>
(cherry picked from commit bbdc941)
Signed-off-by: Wei Fu <fuweid89@gmail.com>
    @fuweid
    fuweid committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2828a12 View commit details
    Browse the repository at this point in the history