Update release.md #18346
Update release.md #18346
Conversation
wenjiaswe
force-pushed
the
wenjiaswe-patch-1
branch
from
4253cd3
to
552955a
Compare
| @@ -62,6 +62,7 @@ which don't need to be executed before releasing each version. | |||
| 4. Authenticate the image registry, refer to [Authentication methods](https://cloud.google.com/container-registry/docs/advanced-authentication). | |||
| - `gcloud auth login` | |||
| - `gcloud auth configure-docker` | |||
| 5. Make sure your Linux machine has at least 5GB free space. | |||
There was a problem hiding this comment.
Hi @wenjiaswe, I suggest rather changing pre-req 2c, that says:
Ensure there is at least 500MB of free space on your Linux machine.
| - Follow the format of previous release pages | ||
| - Attach the generated binaries and signature file | ||
| - Select whether it's a pre-release | ||
| - Publish the release | ||
| 6. Announce to the etcd-dev googlegroup | ||
|
|
||
| Follow the format of previous release emails sent to etcd-dev@googlegroups.com, see an example below, | ||
| Follow the format of previous release emails sent to etcd-dev@googlegroups.com, see an example below. After sending out the email, ask one of the mainterners to approve the email from the pending list. |
There was a problem hiding this comment.
Typo but lets also tweak it to "mailing list maintainers" as this doesn't necessarily have to only be project code maintainers in future 🙂
| Follow the format of previous release emails sent to etcd-dev@googlegroups.com, see an example below. After sending out the email, ask one of the mainterners to approve the email from the pending list. | |
| Follow the format of previous release emails sent to etcd-dev@googlegroups.com, see an example below. After sending out the email, ask one of the mailing list maintainers to approve the email from the pending list. |
|
/retest |
k8s-ci-robot
added
size/XL
area/clientv3
area/performance
area/testing
area/tooling
github_actions
wenjiaswe
force-pushed
the
wenjiaswe-patch-1
branch
from
b2cc789
to
0a90ec8
Compare
wenjiaswe
force-pushed
the
wenjiaswe-patch-1
branch
from
0a90ec8
to
f181ced
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: serathius, wenjiaswe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wenjiaswe: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Update release.md based on 3.5.15 release: #18247 (comment)