-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2024-07-08] Manual Dependency Bump #18310
Conversation
This commit will bump dependency google.golang.org/grpc from 1.64.0 to 1.64.1 raised by dependabot. Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
This commit will bump dependency go.opentelemetry.io/otel from 1.27.0 to 1.28.0 raised by dependabot. Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
…olang.org/grpc/otelgrpc from 0.52.0 to 0.53.0 This commit will bump dependency go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.52.0 to 0.53.0 raised by dependabot. Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
This commit will bump dependency github.com/sivchari/tenv from 1.7.1 to 1.10.0 raised by dependabot. Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
This commit will bump dependency golang.org/x/sys from 0.21.0 to 0.22.0 raised by dependabot. Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
1f70cb0
to
260b6c6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 416 files with indirect coverage changes @@ Coverage Diff @@
## main #18310 +/- ##
=========================================
+ Coverage 0 68.98% +68.98%
=========================================
Files 0 417 +417
Lines 0 35332 +35332
=========================================
+ Hits 0 24373 +24373
- Misses 0 9550 +9550
- Partials 0 1409 +1409 Continue to review full report in Codecov by Sentry.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to confirm the decision on bumping the two indirect dependencies, other than that it looks good, thanks @ArkaSaha30
Thanks @jmhbnz . Yes, please rollback the changes on the two indirect dependencies. @ArkaSaha30 . Please make sure you read and understand https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/dependency_management.md |
260b6c6
to
3dda3b8
Compare
Please remember to comment on the PR that contains only indirect dependencies so the maintainers can easily see and close it! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @ArkaSaha30
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ArkaSaha30, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.
Dependabot raised raised the following PRs: