Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-07-08] Manual Dependency Bump #18310

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Conversation

This commit will bump dependency google.golang.org/grpc from 1.64.0 to 1.64.1 raised by dependabot.

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
This commit will bump dependency go.opentelemetry.io/otel from 1.27.0 to 1.28.0 raised by dependabot.

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
…olang.org/grpc/otelgrpc from 0.52.0 to 0.53.0

This commit will bump dependency go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.52.0 to 0.53.0 raised by dependabot.

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
This commit will bump dependency github.com/sivchari/tenv from 1.7.1 to 1.10.0 raised by dependabot.

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
This commit will bump dependency golang.org/x/sys from 0.21.0 to 0.22.0 raised by dependabot.

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.98%. Comparing base (4d9dceb) to head (61577f9).
Report is 5 commits behind head on main.

Current head 61577f9 differs from pull request most recent head 3dda3b8

Please upload reports for the commit 3dda3b8 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files Coverage Δ
client/v3/watch.go 93.43% <100.00%> (ø)

... and 416 files with indirect coverage changes

@@            Coverage Diff            @@
##           main   #18310       +/-   ##
=========================================
+ Coverage      0   68.98%   +68.98%     
=========================================
  Files         0      417      +417     
  Lines         0    35332    +35332     
=========================================
+ Hits          0    24373    +24373     
- Misses        0     9550     +9550     
- Partials      0     1409     +1409     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d9dceb...3dda3b8. Read the comment docs.

@henrybear327
Copy link
Contributor

/retest

@ahrtr ahrtr changed the title [WIP] [2024-07-08] Manual Dependency Bump [2024-07-08] Manual Dependency Bump Jul 11, 2024
@ahrtr
Copy link
Member

ahrtr commented Jul 12, 2024

cc @jmhbnz @ivanvc

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm the decision on bumping the two indirect dependencies, other than that it looks good, thanks @ArkaSaha30

tools/mod/go.mod Outdated Show resolved Hide resolved
tools/mod/go.mod Outdated Show resolved Hide resolved
@ahrtr
Copy link
Member

ahrtr commented Jul 12, 2024

Just want to confirm the decision on bumping the two indirect dependencies, other than that it looks good, thanks @ArkaSaha30

Thanks @jmhbnz .

Yes, please rollback the changes on the two indirect dependencies. @ArkaSaha30 . Please make sure you read and understand https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/dependency_management.md

@henrybear327
Copy link
Contributor

Just want to confirm the decision on bumping the two indirect dependencies, other than that it looks good, thanks @ArkaSaha30

Thanks @jmhbnz .

Yes, please rollback the changes on the two indirect dependencies. @ArkaSaha30 . Please make sure you read and understand https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/dependency_management.md

Please remember to comment on the PR that contains only indirect dependencies so the maintainers can easily see and close it! :)

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ArkaSaha30

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ArkaSaha30, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit bc9801f into etcd-io:main Jul 12, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants