Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/release: shallow clone repository #18095

Merged
merged 1 commit into from
May 30, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented May 29, 2024

Minor improvement that was identified when releasing v3.5.14.

Related to #18013.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc
Copy link
Member Author

ivanvc commented May 30, 2024

/retest

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ivanvc

@serathius serathius merged commit 2f216dc into etcd-io:main May 30, 2024
45 checks passed
@ivanvc ivanvc deleted the shallow-clone-in-release-script branch May 30, 2024 15:02
@ivanvc
Copy link
Member Author

ivanvc commented May 30, 2024

@jmhbnz, should we backport this into 3.4 too?

@jmhbnz
Copy link
Member

jmhbnz commented May 30, 2024

@jmhbnz, should we backport this into 3.4 too?

Personally I think yes to try and keep release process consistent and given we believe this to be a low risk improvement. Though this decision would be to @ahrtr as overall release manager for 3.4. Also ref: #17677 (comment)

@ahrtr
Copy link
Member

ahrtr commented May 30, 2024

@ivanvc please feel free to deliver a PR to 3.4. thx

ivanvc added a commit to ivanvc/etcd that referenced this pull request May 31, 2024
Backport of commit 4881e53 / pull
request etcd-io#18095.

Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc added a commit to ivanvc/etcd that referenced this pull request May 31, 2024
Backport of commit 4881e53 / pull
request etcd-io#18095.

Signed-off-by: Ivan Valdes <ivan@vald.es>
aneesh1 pushed a commit to DataDog/etcd that referenced this pull request Sep 24, 2024
Backport of commit 4881e53 / pull
request etcd-io#18095.

Signed-off-by: Ivan Valdes <ivan@vald.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants