raft: add handleHeartbeat #1740
Conversation
xiang90
force-pushed
the
handleheartbeat
branch
from
29e76b1
to
24a9bfe
Compare
| } | ||
| l.committed = tocommit | ||
| } | ||
| } |
There was a problem hiding this comment.
add a specific test for it?
|
we need to make corresponded change at https://github.com/coreos/etcd/blob/master/raft/raft.go#L432, which handles heartbeat response before. |
| HardState: pb.HardState{Term: 2}, | ||
| raftLog: &raftLog{committed: 0, ents: []pb.Entry{{}, {Term: 1}, {Term: 2}, {Term: 3}}}, | ||
| } | ||
| sm.raftLog.commitTo(2) |
There was a problem hiding this comment.
sm.raftLog.commitTo(commit)
handleHeartbeat commits to the commit index in the message. It never decreases the commit index of the raft state machine.
xiang90
force-pushed
the
handleheartbeat
branch
from
24a9bfe
to
bd4cfa2
Compare
|
done. I am not going to change the heartbeat response handling logic at leader side, since we are not sure if we will add the heartbeat response back soon. We can revisit all these sort of thing when we introduce the |
| if l.committed < tocommit { | ||
| l.committed = tocommit | ||
| } | ||
| l.commitTo(min(committed, lastnewi)) |
There was a problem hiding this comment.
@bdarnell You probably need to do a rebase due to this change. :(
There was a problem hiding this comment.
I don't think this change will be a problem, actually, since I haven't really touched the commit logic. I have, however, had to do a number of non-trivial merges for changes around stableTo(). Once I finish up the snapshot stuff I'm currently working on I think my branch will be ready to merge back into the mainline.
|
lgtm |
handleHeartbeat commits to the commit index in the message. It never decreases the
commit index of the raft state machine.