Add verification on keys: should be always moronically increasing #17290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
4 tasks
serathius
reviewed
Jan 25, 2024
| @@ -52,7 +54,20 @@ func (txw *txWriteBuffer) put(bucket Bucket, k, v []byte) { | |||
| } | |||
|
|
|||
| func (txw *txWriteBuffer) putSeq(bucket Bucket, k, v []byte) { | |||
| // TODO: Add (in tests?) verification whether k>b[len(b)] | |||
| // putSeq is only be called for the data in the Key bucket. The keys | |||
There was a problem hiding this comment.
Could we merge verify independent of the fix?
|
Can this be closed and work continued in #17263 ? |
We can close this one, but we should double confirm #17247 (comment) before continuing to work on #17263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second solution to #17247.
This solution is much simpler, and easy to understand. But it only verifies the write buffer. It doesn't verify the merged data (write and read buffer).
It also adds unnecessary sorting and deduplicating on the Key bucket, so in theory it may have a little impact on the performance. Need to run benchmark to double confirm how much performance reduction it may lead to.