-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add workflow telemetry to collect action metrics #17046
Conversation
part of etcd-io#17045 Signed-off-by: Mofi Rahman <mofi@google.com>
Hi @moficodes. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@jmhbnz do you know how the metrics become available to view? |
hmm The action post failed.
|
Hey @moficodes - I can see some results here for example: https://github.com/etcd-io/etcd/actions/runs/7051472834/attempts/1#summary-19194441512 Can you check across all three (e2e, tests and robustness) and confirm we have results available for |
@jmhbnz is there a list for all the possible actuated machine types? Or is it dynamically provisioned based on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @moficodes - I would like to collect some samples for a few days to make sure there are no outliers.
This pr LGTM so let's merge, collect some data for a few days and then @fykaa will raise the follow-up pr to reduce the ram requests and disable the telemetry.
Based on #16801 (comment) I believe there is dynamic sizing/provisioning so we can just set the value and it will just work. |
Saw the following errors in "Post Collect Workflow Telemetry", but it seems the reports were already successfully uploaded,
|
Just noticed that you already raised an issue catchpoint/workflow-telemetry-action#53. Thanks. |
part of #17045