Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to validating v3 when v2 and v3 are synchronized #17017

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

serathius
Copy link
Member

@serathius serathius commented Nov 24, 2023

This PR is not very useful, but let's merge it to clarify how validation should look like as long as we bootstrap from v2 store

Alternatives proposed before:

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Copy link
Member Author

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr
Copy link
Member

ahrtr commented Nov 27, 2023

Alternatives proposed before:

To be clearer, It isn't an alternative solution. This PR is just a solution on top of #16084 with a further fix (thx for that). I would raise a comment on 16084 and honor the original author's work (@geetasg, thanks for your contribution & patience).

@ahrtr ahrtr merged commit e1d7909 into etcd-io:main Nov 27, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants