-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies #16210
Bump dependencies #16210
Conversation
Signed-off-by: Benjamin Wang <wachao@vmware.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
As part of the net stdlib update, from what I read from golang/go#58804 (comment), we should switch back http server to use default scheduler, is that understanding correct? Lines 269 to 276 in 1f07d8f
|
@chaochn47 It's an unrelated comment, please raise the comment in #15402. Per my understanding, with the merge of 120fc90, the production code change in #15431 isn't necessary, but it will NOT do any harm and the test case still makes sense. BTW, the golang std lid commit 260a9b0a0 will only be included in golang 1.21+. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thx @chaochn47 and @jmhbnz for the quick review. |
Please see commit messages, each of them bumps one dependency.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.