Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.4] clientv3: create keepAliveCtxCloser goroutine only if ctx can be canc… #16202

Merged
merged 1 commit into from
Jul 14, 2023
Merged

[3.4] clientv3: create keepAliveCtxCloser goroutine only if ctx can be canc… #16202

merged 1 commit into from
Jul 14, 2023

Conversation

kensou97
Copy link
Contributor

@kensou97
clientv3: create keepAliveCtxCloser goroutine only if ctx can be canc…
30426eb 
…eled

Signed-off-by: zhangwenkang <zwenkang@vmware.com>
jmhbnz
jmhbnz approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr ahrtr merged commit 8175511 into etcd-io:release-3.4 Jul 14, 2023
@ahrtr ahrtr mentioned this pull request Oct 27, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kensou97 @ahrtr @jmhbnz