Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: move .golangci.yaml to tools dir #16022

Merged
merged 1 commit into from
Jun 7, 2023
Merged

ci: move .golangci.yaml to tools dir #16022

merged 1 commit into from
Jun 7, 2023

Conversation

tao12345666333
Copy link
Contributor

@tao12345666333
ci: move .golangci.yaml to tools dir
0f32b58 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 marked this pull request as ready for review June 6, 2023 11:52
ahrtr
ahrtr approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @tao12345666333

jmhbnz
jmhbnz approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for tidying these up @tao12345666333 👍🏻

@ahrtr
Copy link
Member

ahrtr commented Jun 7, 2023

I am used to run golangci-lint run before delivering a PR, so the only minor minor comment is it doesn't work any more. I have to provide argument --config tools/.golangci.yaml or execute make verify-lint.

@ahrtr ahrtr merged commit faf5945 into etcd-io:main Jun 7, 2023
@tao12345666333 tao12345666333 deleted the clean-root-dir branch June 7, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

@ahrtr ahrtr ahrtr approved these changes

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move .golangci.yaml out of top level directory to reduce clutter
4 participants
@tao12345666333 @ahrtr @serathius @jmhbnz