common test: update auth test interface #14626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaochn47
force-pushed
the
auth_test_fix
branch
from
b3b4a81
to
425970e
Compare
ahrtr
reviewed
Oct 26, 2022
chaochn47
force-pushed
the
auth_test_fix
branch
from
425970e
to
8eb88fd
Compare
chaochn47
force-pushed
the
auth_test_fix
branch
from
8eb88fd
to
4bd9af2
Compare
Codecov Report
@@ Coverage Diff @@
## main #14626 +/- ##
==========================================
- Coverage 75.39% 75.37% -0.03%
==========================================
Files 457 457
Lines 37271 37271
==========================================
- Hits 28101 28093 -8
- Misses 7396 7406 +10
+ Partials 1774 1772 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chaochn47
force-pushed
the
auth_test_fix
branch
3 times, most recently
from
9818ffe
to
206414a
Compare
Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
force-pushed
the
auth_test_fix
branch
from
206414a
to
f3c47d7
Compare
|
This should be a safe change, let me merge it right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withAuthoption in common test entry pointNewEtcdctlaccepts a client option that could have invalid user name and password, it should fail client creation. I am happy to add more comments to reduce the confusion.AuthEnableandAuthDisabledoes not need response in the function signature.@ahrtr @serathius