[e2e] Fix AuthEnable/Disable e2e test implementations #14608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Guba <oleg@dropbox.com>
ahrtr
reviewed
Oct 21, 2022
|
Please signoff the commit. |
address comment Co-authored-by: Benjamin Wang <wachao@vmware.com> Signed-off-by: Oleg Guba <oleg@dropbox.com>
address comment Co-authored-by: Benjamin Wang <wachao@vmware.com> Signed-off-by: Oleg Guba <oleg@dropbox.com>
done. |
ahrtr
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
etcdctl AuthEnable and AuthDisable subcommands does not support json output and produce single-line output even is json mode is requested.
Existing implementations does not work correctly in newly added e2e test.
Splitting #14574 into multiple PRs.
Signed-off-by: Oleg Guba oleg@dropbox.com