[test] Support dynamically adding & starting new member #14589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebased this PR. There is no response from the original author, so Benjamin (ahrtr@) continue to work on this PR. Signed-off-by: Vitalii Levitskii <vitalii@uber.com> Signed-off-by: Benjamin Wang <wachao@vmware.com>
…w member Signed-off-by: Benjamin Wang <wachao@vmware.com>
|
@spzala @mitake @serathius @ptabor The original PR is already well reviewed, so please only take a look at the second commit 24ad490 . |
Codecov Report
@@ Coverage Diff @@
## main #14589 +/- ##
==========================================
- Coverage 75.58% 75.44% -0.14%
==========================================
Files 457 457
Lines 37213 37213
==========================================
- Hits 28126 28076 -50
- Misses 7329 7366 +37
- Partials 1758 1771 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks @spzala |
|
I was unavailable, sorry. Thanks for finishing PR! |
This was referenced Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue to work on #14404, because there is no response from the original author for a long time.
We need to resolve this because the other PR #14574 is blocked by this one
cc @spzala @mitake @serathius @ptabor
cc @veshij @biosvs