Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdctl: allow move-leader to connect to multiple endpoints #14307

Closed
wants to merge 2 commits into from
Closed

etcdctl: allow move-leader to connect to multiple endpoints #14307

wants to merge 2 commits into from

Commits on Aug 3, 2022

  1. etcdctl: allow move-leader to connect to multiple endpoints 

    Re-opening closed PR etcd-io#11775 which was originaly authored by benmoss.
Then again opened PR etcd-io#12757 which was authored by zerodayz.

The mustClientForCmd function is responsible for parsing environment
variables and flags into configuration data. A change was made in etcd-io#9382
to call Fatal if a flag is provided multiple times. This means that we
cannot call the mustClientForCmd function more than once,
since it will think that flags parsed the first time are now
being redefined and error out.

Some people have commented about this in etcd-io#8380 but I don't think
there's an open issue for it.

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
    @tjungblu
    tjungblu committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    208d9f9 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. refactoring the regression test 

    Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
    @tjungblu
    tjungblu committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    319968f View commit details
    Browse the repository at this point in the history