Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce ExpectFunc polling interval #14283

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Reduce ExpectFunc polling interval #14283

merged 1 commit into from
Jul 28, 2022

Conversation

tjungblu
Copy link
Contributor

Fixes issue #14275, flakes close to timeout like TestKVDelete.

Signed-off-by: Thomas Jungblut tjungblu@redhat.com

@tjungblu
Reduce ExpectFunc polling interval.
eb59368 
Fixes issue 14275, flakes close to timeout like TestKVDelete.

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
serathius
serathius approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@serathius serathius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!
You can also see e2e test duration reduced from 16 to 13 minutes.
There should be an achievement for getting 1 character change merged.

@serathius serathius merged commit 223b33f into etcd-io:main Jul 28, 2022
@tjungblu tjungblu deleted the issue_14275 branch July 28, 2022 13:04
@serathius serathius mentioned this pull request Jul 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjungblu @serathius