[3.4] etcdserver: resend ReadIndex request on empty apply request #14269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport etcd-io#12795 to 3.4 Signed-off-by: Benjamin Wang <wachao@vmware.com>
|
@serathius This may be the last backport PR for 3.4. |
serathius
approved these changes
Jul 25, 2022
|
Sad we don't have e2e tests for this. |
This can only be accurately tested by integration test, but unfortunately we don't have integrate test at all in release-3.4. But I believe the existing changing leader e2e cases should can also cover the code change in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #12795 and #12780 to 3.4. There is any integration test at all in release-3.4, so the integration test case isn't backported to 3.4.
part of #14232.
Signed-off-by: Benjamin Wang wachao@vmware.com
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.