Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Use zaptest.NewLogger in tests #13867

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

serathius
Copy link
Member

Copy link
Contributor

@ptabor ptabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving this.

Please fix the failing tests:

stderr: # go.etcd.io/etcd/pkg/v3/flags
Error: stderr: vet: flags/flag_test.go:52:25: undeclared name: zaptest
stderr: # go.etcd.io/etcd/pkg/v3/netutil
Error: stderr: vet: netutil/netutil_test.go:[133](https://github.com/etcd-io/etcd/runs/5785482962?check_suite_focus=true#step:5:133):37: undeclared name: zaptest
stderr: # go.etcd.io/etcd/pkg/v3/osutil
Error: stderr: vet: osutil/osutil_test.go:74:20: undeclared name: zaptest

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #13867 (d300079) into main (b161093) will decrease coverage by 0.25%.
The diff coverage is n/a.

❗ Current head d300079 differs from pull request most recent head 804fddf. Consider uploading reports for the commit 804fddf to get more accurate results

@@            Coverage Diff             @@
##             main   #13867      +/-   ##
==========================================
- Coverage   72.61%   72.36%   -0.26%     
==========================================
  Files         467      468       +1     
  Lines       38296    38232      -64     
==========================================
- Hits        27809    27665     -144     
- Misses       8714     8774      +60     
- Partials     1773     1793      +20     
Flag Coverage Δ
all 72.36% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raft/raft.go 90.18% <ø> (-0.25%) ⬇️
server/proxy/grpcproxy/register.go 69.76% <0.00%> (-9.31%) ⬇️
server/storage/schema/version.go 73.91% <0.00%> (-8.70%) ⬇️
server/auth/simple_token.go 80.00% <0.00%> (-8.47%) ⬇️
client/v3/namespace/watch.go 87.87% <0.00%> (-6.07%) ⬇️
client/v3/concurrency/mutex.go 61.64% <0.00%> (-5.48%) ⬇️
server/etcdserver/api/v3rpc/watch.go 83.55% <0.00%> (-5.37%) ⬇️
server/etcdserver/api/v3rpc/lease.go 77.21% <0.00%> (-5.07%) ⬇️
raft/rafttest/node.go 95.00% <0.00%> (-5.00%) ⬇️
client/v3/concurrency/session.go 88.63% <0.00%> (-4.55%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b161093...804fddf. Read the comment docs.

@ptabor ptabor merged commit 6c974a3 into etcd-io:main Apr 4, 2022
@serathius serathius deleted the logs-test branch June 15, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants