-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration: Test flakiness fixes #12782
Conversation
ptabor
commented
Mar 16, 2021
•
edited
Loading
edited
- Fixed 2 cases of leaking go-routines from core-logic (e.g. embed was not stopping HTTP server)
- Enforced BeforeTest in all integrational tests.
- TestBalancerUnderNetworkPartitionWatch* are not picking server they talk to semi-randomly, so are guaranteed to be connected to 'separated' node to confirm WithLeader behavior of watch.
The CL disallows to create NewCluster in tests without BeforeTest.
Codecov Report
@@ Coverage Diff @@
## master #12782 +/- ##
==========================================
- Coverage 72.24% 66.37% -5.87%
==========================================
Files 427 404 -23
Lines 33159 31946 -1213
==========================================
- Hits 23955 21205 -2750
- Misses 7271 8802 +1531
- Partials 1933 1939 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM