Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated functions with new grpc functions (Picker V2) #12439

Closed
wants to merge 1 commit into from
Closed

Replace deprecated functions with new grpc functions (Picker V2) #12439

wants to merge 1 commit into from

Conversation

agargi
Copy link
Contributor

@agargi agargi commented Nov 1, 2020

balancer: Replace deprecated functions with new grpc version

@agargi agargi force-pushed the replace_deprecated_functions branch from 34276cb to 07f5986 Compare November 1, 2020 19:31
@agargi agargi force-pushed the replace_deprecated_functions branch from 07f5986 to 5611ae5 Compare November 2, 2020 00:14
@agargi agargi changed the title Replace deprecated functions with new grpc version Replace deprecated functions with new grpc functions Nov 2, 2020
jingyih
jingyih reviewed Nov 6, 2020
View reviewed changes
Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Is there any semantic change due to function replacing?

@ptabor ptabor mentioned this pull request Nov 12, 2020
Closed
@agargi
Copy link
Contributor Author

agargi commented Nov 14, 2020 •
edited
Loading

semantic change due to function replacing

No

@jingyih Can you pls review and see it can be taken further?

@ptabor ptabor mentioned this pull request Dec 21, 2020
Closed
@ptabor ptabor self-assigned this Jan 16, 2021
@ptabor ptabor changed the title Replace deprecated functions with new grpc functions Replace deprecated functions with new grpc functions (Picker V2) Jan 30, 2021
@ptabor ptabor mentioned this pull request Jan 30, 2021
Closed
@ptabor ptabor self-requested a review January 31, 2021 22:43
@ptabor
Copy link
Contributor

ptabor commented Feb 2, 2021

I merged equivalent #12658, so closing this one.
I'm sorry for not driving this earlier.

@ptabor ptabor closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingyih jingyih jingyih left review comments

@ptabor ptabor Awaiting requested review from ptabor

Assignees

@ptabor ptabor

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agargi @ptabor @jingyih