Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Update tools & go.mod for protos (gogo/protobuf 1.3.1, grpc 1.29.1, grpc-gateway 1.14.6) #12397

Merged
merged 3 commits into from
Oct 14, 2020

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented Oct 14, 2020

tools: Update of go.mod for protos (gogo/protobuf 1.3.1, grpc 1.29.1, grpc-gateway 1.14.6)

This brings consistency between proto-generation code and actual versions of libraries being used in runtime:

    github.com/gogo/protobuf                        v1.2.1,v1.0.0 -> v1.3.1
    github.com/golang/protobuf                             v1.3.2 -> v1.3.5
    github.com/grpc-ecosystem/grpc-gateway  v1.9.5,v1.4.1,v1.15.2 -> v1.14.6
    google.golang.org/grpc                                v1.26.0 -> v1.29.1

Moved as far as possible, without bumping on grpc 1.30.0 "naming" decomissioning.

Please also notice that gogo/protobuf is likely to reach EOL: gogo/protobuf#691,
so we should consider migration to the other generator.

… grpc-gateway 1.14.6)

This brings consistency between proto-generation code and actual versions of libraries being used in runtime:

github.com/gogo/protobuf                        v1.2.1,v1.0.0 -> v1.3.1
github.com/golang/protobuf                             v1.3.2 -> v1.3.5
github.com/grpc-ecosystem/grpc-gateway  v1.9.5,v1.4.1,v1.15.2 -> v1.14.6
google.golang.org/grpc                                v1.26.0 -> v1.29.1

Moved as far as possible, without bumping on grpc 1.30.0 "naming" decomissioning.
Please also notice that gogo/protobuf is likely to reach EOL: gogo/protobuf#691
@xiang90
Copy link
Contributor

xiang90 commented Oct 14, 2020

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants