etcdctl: add hex option for endpoint status #12110
Conversation
|
have you tested it out? example output? |
-bash-4.4# etcdctl endpoint status -w json --hex | jq Without hex: |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
|
LGTM. Can you change commit message to "etcdctl: add hex option for endpoint status"? |
…enisRazinkin/etcd into fix-issue-9975-endpoint-status
DenisRazinkin
changed the title
|
CI still failing. You need to merge the 3 commits into one. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
| var buffer bytes.Buffer | ||
| var b []byte | ||
|
|
||
| buffer.WriteString("[") |
There was a problem hiding this comment.
Please avoid "hand-crafting" of JSON format as it might have subtle escaping consequences.
Please see discussion in:
#12595 (comment)
| proc, err := spawnCmd(cmdArgs) | ||
| if err != nil { | ||
| cx.t.Fatalf("endpointStatusHexTest error (%v)", err) | ||
| } |
There was a problem hiding this comment.
Please verify the test output (printed format).
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
Please read https://github.com/etcd-io/etcd/blob/master/CONTRIBUTING.md#contribution-flow.