Automated cherry pick of #8242 to release-3.2

[wenjiaswe]

Cherry pick of #8242 on release-3.2.

#8242: embed: configure 'ListenMetricsUrls'

[wenjiaswe]

/assign @gyuho

Gyuho, would you please help to review this? xref: #8242 (comment)
One thing that I am not sure about this cherry pick is that in the original PR, there are some code change in etcdmain/grpc_proxy.go, but it looks like those diff are handled by #9894 and not needed in this cherrypick PR. But if I could get your confirmation that would be great!

[hexfusion]

While I would love this isn’t this a feature? In general we do not backport feature for patch releases. Defer to @jpbetz

On Tue, Mar 19, 2019 at 6:15 PM Wenjia ***@***.***> wrote: Cherry pick of #8242 <#8242> on release-3.2. #8242 <#8242>: embed: configure 'ListenMetricsUrls' ------------------------------ You can view, comment on, or merge this pull request online at: #10559 Commit Summary - embed: configure 'ListenMetricsUrls' - etcdmain: add 'listen-metrics-urls' option File Changes - *M* embed/config.go <https://github.com/etcd-io/etcd/pull/10559/files#diff-0> (15) - *M* embed/etcd.go <https://github.com/etcd-io/etcd/pull/10559/files#diff-1> (25) - *M* etcdmain/config.go <https://github.com/etcd-io/etcd/pull/10559/files#diff-2> (12) - *M* etcdmain/etcd.go <https://github.com/etcd-io/etcd/pull/10559/files#diff-3> (2) - *M* etcdmain/help.go <https://github.com/etcd-io/etcd/pull/10559/files#diff-4> (6) Patch Links: - https://github.com/etcd-io/etcd/pull/10559.patch - https://github.com/etcd-io/etcd/pull/10559.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#10559>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABMR1QXGzlwh65T4UaWN3YVHFfP13cMAks5vYWF4gaJpZM4b9Olv> .

-- —

[jpbetz]

Yes, there exist etcd 3.3.x versions without this fix. So if we add it to 3.2, and someone starts using the flag with etcd 3.2.x and then upgrades to a 3.3.x that does not support the flag, etcd will fail to start. Let's not backport this.

[wenjiaswe]

@jpbetz yes, you are right. I will close this.