Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change imports to coreos/etcd coreos/go-raft #1

Merged
merged 1 commit into from
Jul 8, 2013

Conversation

xiang90
Copy link
Contributor

@xiang90 xiang90 commented Jul 8, 2013

No description provided.

@polvi
Copy link
Contributor

polvi commented Jul 8, 2013

In the future please put these changes in two different commits. 1) the library changes, 2) API changes.

polvi added a commit that referenced this pull request Jul 8, 2013
Change imports to coreos/etcd coreos/go-raft
@polvi polvi merged commit cd2355e into etcd-io:master Jul 8, 2013
xiang90 added a commit that referenced this pull request Jul 14, 2013
benbjohnson added a commit that referenced this pull request Oct 14, 2013
fix server/server.go accept name when creating a when server; gofmt
philips added a commit that referenced this pull request Feb 4, 2014
test(TLS): Add test coverage for etcd TLS
philips added a commit that referenced this pull request Jun 25, 2014
fix(CONTRIBUTING.md): Fix title case
yichengq pushed a commit that referenced this pull request Aug 28, 2014
Pull coreos changes into this fork
bdarnell added a commit to bdarnell/etcd that referenced this pull request Nov 11, 2014
Initial implementation of raft.MultiNode.
mitake added a commit to mitake/etcd that referenced this pull request Nov 5, 2015
Current etcdserver just returns an error message "Internal Server
Error" in a case of internal error. This message isn't friendly and
not so useful for diagnosis. In addition, etcdctl just reports
"client: etcd cluster is unavailable or misconfigured" in such a case.

This commit improves the error message. The new body of error response
is now generated based on an error code of etcdserver. The client
constructs more friendly error message based on the response.

Below is an example:

Before:
 $ etcdctl member add infra6 http://127.0.0.1:32338
 client: etcd cluster is unavailable or misconfigured

After:
 $ etcdctl member add infra6 http://127.0.0.1:32338
 error #0: client: etcd member http://127.0.0.1:12379: etcdserver: re-configuration failed due to not enough started members
 error etcd-io#1: client: etcd member http://127.0.0.1:22379: etcdserver: re-configuration failed due to not enough started members
 error etcd-io#2: client: etcd member http://127.0.0.1:32379: etcdserver: re-configuration failed due to not enough started members
mitake added a commit to mitake/etcd that referenced this pull request Nov 6, 2015
Current etcdserver just returns an error message "Internal Server
Error" in a case of internal error. This message isn't friendly and
not so useful for diagnosis. In addition, etcdctl just reports
"client: etcd cluster is unavailable or misconfigured" in such a case.

This commit improves the error message. The new body of error response
is now generated based on an error code of etcdserver. The client
constructs more friendly error message based on the response.

Below is an example:

Before:
 $ etcdctl member add infra6 http://127.0.0.1:32338
 client: etcd cluster is unavailable or misconfigured

After:
 $ etcdctl member add infra6 http://127.0.0.1:32338
 error #0: client: etcd member http://127.0.0.1:12379: etcdserver: re-configuration failed due to not enough started members
 error etcd-io#1: client: etcd member http://127.0.0.1:22379: etcdserver: re-configuration failed due to not enough started members
 error etcd-io#2: client: etcd member http://127.0.0.1:32379: etcdserver: re-configuration failed due to not enough started members
@houstar houstar mentioned this pull request Jan 6, 2017
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this pull request May 19, 2017
@willkk willkk mentioned this pull request Dec 20, 2017
namreg pushed a commit to namreg/etcd that referenced this pull request Dec 15, 2018
use set instead of slice as interval value

fixes etcd-io#1
jkessler93 pushed a commit to jkessler93/etcd that referenced this pull request Jan 17, 2019
WIZARD-CXY pushed a commit to WIZARD-CXY/etcd that referenced this pull request Mar 21, 2019
*: Change etcdserver API to support raft learner
galal-hussein added a commit to galal-hussein/etcd that referenced this pull request Nov 24, 2020
Add ConfChangeAddLearnerNode to the list of config changes
ahrtr added a commit that referenced this pull request Dec 9, 2022
$ govulncheck ./...
govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Scanning for dependencies with known vulnerabilities...
Found 1 known vulnerability.

Vulnerability #1: GO-2022-1144
  An attacker can cause excessive memory growth in a Go server
  accepting HTTP/2 requests. HTTP/2 server connections contain a
  cache of HTTP header keys sent by the client. While the total
  number of entries in this cache is capped, an attacker sending
  very large keys can cause the server to allocate approximately
  64 MiB per open connection.

  Call stacks in your code:
      tools/etcd-dump-metrics/main.go:159:31: go.etcd.io/etcd/v3/tools/etcd-dump-metrics.main$4 calls go.etcd.io/etcd/server/v3/embed.StartEtcd, which eventually calls golang.org/x/net/http2.ConfigureServer$1

  Found in: golang.org/x/net/http2@v0.2.0
  Fixed in: golang.org/x/net/http2@v1.19.4
  More info: https://pkg.go.dev/vuln/GO-2022-1144

Vulnerability #2: GO-2022-1144
  An attacker can cause excessive memory growth in a Go server
  accepting HTTP/2 requests. HTTP/2 server connections contain a
  cache of HTTP header keys sent by the client. While the total
  number of entries in this cache is capped, an attacker sending
  very large keys can cause the server to allocate approximately
  64 MiB per open connection.

  Call stacks in your code:
      contrib/lock/storage/storage.go:106:28: go.etcd.io/etcd/v3/contrib/lock/storage.main calls net/http.ListenAndServe
      contrib/raftexample/httpapi.go:113:31: go.etcd.io/etcd/v3/contrib/raftexample.serveHTTPKVAPI$1 calls net/http.Server.ListenAndServe
      tools/etcd-dump-metrics/main.go:159:31: go.etcd.io/etcd/v3/tools/etcd-dump-metrics.main$4 calls go.etcd.io/etcd/server/v3/embed.StartEtcd, which eventually calls net/http.Serve
      tools/etcd-dump-metrics/main.go:159:31: go.etcd.io/etcd/v3/tools/etcd-dump-metrics.main$4 calls go.etcd.io/etcd/server/v3/embed.StartEtcd, which eventually calls net/http.Server.Serve

  Found in: net/http@go1.19.3
  Fixed in: net/http@go1.19.4
  More info: https://pkg.go.dev/vuln/GO-2022-1144

Signed-off-by: Benjamin Wang <wachao@vmware.com>
ahrtr added a commit that referenced this pull request Dec 9, 2022
Found 1 known vulnerability.

Vulnerability #1: GO-2022-1144
  An attacker can cause excessive memory growth in a Go server
  accepting HTTP/2 requests. HTTP/2 server connections contain a
  cache of HTTP header keys sent by the client. While the total
  number of entries in this cache is capped, an attacker sending
  very large keys can cause the server to allocate approximately
  64 MiB per open connection.

  Call stacks in your code:
Error:       tools/etcd-dump-metrics/main.go:158:5: go.etcd.io/etcd/v3/tools/etcd-dump-metrics.main calls go.etcd.io/etcd/server/v3/embed.StartEtcd, which eventually calls golang.org/x/net/http2.Server.ServeConn

  Found in: golang.org/x/net/http2@v0.2.0
  Fixed in: golang.org/x/net/http2@v0.4.0
  More info: https://pkg.go.dev/vuln/GO-2022-1144
Error: Process completed with exit code 3.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
ahrtr pushed a commit that referenced this pull request Dec 17, 2022
Signed-off-by: Chao Chen <chaochn@amazon.com>
ahrtr added a commit that referenced this pull request Dec 17, 2022
serathius pushed a commit that referenced this pull request Jan 1, 2023
Signed-off-by: Chao Chen <chaochn@amazon.com>
wafuwafu13 pushed a commit to wafuwafu13/etcd that referenced this pull request Jan 5, 2023
Signed-off-by: Chao Chen <chaochn@amazon.com>
@geetasg geetasg mentioned this pull request Jul 24, 2023
21 tasks
ahrtr pushed a commit that referenced this pull request Jun 14, 2024
Extracted log from govulncheck, suggesting that we should bump the
version of golang.org/x/net

=== Symbol Results ===

Vulnerability #1: GO-2024-2687
    HTTP/2 CONTINUATION flood in net/http
  More info: https://pkg.go.dev/vuln/GO-2024-2687
  Module: golang.org/x/net
    Found in: golang.org/x/net@v0.17.0
    Fixed in: golang.org/x/net@v0.23.0

Reference:
- #17708

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
ahrtr pushed a commit that referenced this pull request Jun 14, 2024
…ab57 to v0.0.0-20220412211240-33da011f77ad

Extracted log from govulncheck, suggesting that we should bump the
version of golang.org/x/sys

Vulnerability #1: GO-2022-0493
    Incorrect privilege reporting in syscall and golang.org/x/sys/unix
  More info: https://pkg.go.dev/vuln/GO-2022-0493
  Module: golang.org/x/sys
    Found in: golang.org/x/sys@v0.0.0-20210403161142-5e06dd20ab57
    Fixed in: golang.org/x/sys@v0.0.0-20220412211240-33da011f77ad

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants