Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: improve test coverage #9734

Closed
gyuho opened this issue May 17, 2018 · 4 comments
Closed

auth: improve test coverage #9734

gyuho opened this issue May 17, 2018 · 4 comments
Labels
area/auth area/testing
Milestone
etcd-v3.4

Comments

@gyuho
Copy link
Contributor

gyuho commented May 17, 2018

Package auth current test coverage is 56% https://codecov.io/gh/coreos/etcd. Improve coverage where it makes sense. For example, HasRole is not being tested https://codecov.io/gh/coreos/etcd/tree/master/auth. And panic from JWT token #9695 should have been prevented by unit tests.
@gyuho gyuho added this to the etcd-v3.4 milestone May 17, 2018
@essamhassan
Copy link
Contributor

I'd love to help with this issue

@hexfusion
Copy link
Contributor

@essamhassan great, love to have you on this. Could you coordinate with @joelegasse to make sure there is no overlap in work etc? Thanks!

@essamhassan
Copy link
Contributor

Great, will do. Is there a slack team chat or any similar way to contact @joelegasse ? we can coordinate the work there

@joelegasse joelegasse removed their assignment Sep 13, 2018
@hexfusion
Copy link
Contributor

@essamhassan I spoke with Joe and he has nothing pending so full steam ahead!

essamhassan added a commit to essamhassan/etcd that referenced this issue Sep 30, 2018
@essamhassan
Auth: improve auth coverage
0409565 
adds tests for uncovered auth funcs

Issue etcd-io#9734
@essamhassan essamhassan mentioned this issue Sep 30, 2018
Merged
essamhassan added a commit to essamhassan/etcd that referenced this issue Sep 30, 2018
@essamhassan
Auth: improve auth coverage
ec7b1fc 
adds tests for uncovered auth funcs

Issue etcd-io#9734
essamhassan added a commit to essamhassan/etcd that referenced this issue Oct 1, 2018
@essamhassan
Auth: improve auth coverage
ffbdb45 
adds tests for uncovered auth funcs

Issue etcd-io#9734
@gyuho gyuho closed this as completed Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/auth area/testing
Milestone
etcd-v3.4
Development

No branches or pull requests
4 participants
@hexfusion @joelegasse @essamhassan @gyuho