Run arm64 e2e tests for every pull request rather than on nightly schedule
#16893
Assignees
Comments
|
Hi @jmhbnz please assign this issue to me. |
|
One further thought for this issue @mingli103. Now that we are moving to Currently we have:
Moving forward we can just rename |
mingli103
added a commit
to mingli103/etcd
that referenced
this issue
Nov 15, 2023
…tcd-io#16912 KubeconNA 2023 Contribfest issue etcd-io#16893 . Recently in etcd-io#16801 we introduced on demand github actions runners for the arm64 platform. Having on demand runner infrastructure in place means we should now have enough capacity to begin running arm64 tests for every pull request. Currently we have: .github/workflows/e2e-arm64-template.yaml - Shared template .github/workflows/e2e-arm64-nightly.yaml - Runs template against both release-3.5 and main branches nightly. Moving forward we can just rename .github/workflows/e2e-arm64-template.yaml to .github/workflows/e2e-arm64.yaml and delete the other file. We can then just make the template file a standard workflow that will run on pull request. Signed-off-by: Ming Li <mli103hawk@gmail.com>
mingli103
added a commit
to mingli103/etcd
that referenced
this issue
Nov 18, 2023
…tcd-io#16912 KubeconNA 2023 Contribfest issue etcd-io#16893 . Recently in etcd-io#16801 we introduced on demand github actions runners for the arm64 platform. Having on demand runner infrastructure in place means we should now have enough capacity to begin running arm64 tests for every pull request. Currently we have: .github/workflows/e2e-arm64-template.yaml - Shared template .github/workflows/e2e-arm64-nightly.yaml - Runs template against both release-3.5 and main branches nightly. Moving forward we can just rename .github/workflows/e2e-arm64-template.yaml to .github/workflows/e2e-arm64.yaml and delete the other file. We can then just make the template file a standard workflow that will run on pull request. Signed-off-by: Ming Li <mli103hawk@gmail.com>
|
Closed as completed in #16950, thanks @mingli103 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What would you like to be added?
Recently in #16801 we introduced on demand github actions runners for the
arm64platform.Having on demand runner infrastructure in place means we should now have enough capacity to begin running
arm64tests for every pull request.We should update our
.github/workflows/e2e-arm64-nightly.yamlworkflow to switch from scheduled nightly runs to instead runningon: [push, pull_request]: https://github.com/etcd-io/etcd/blob/main/.github/workflows/e2e-arm64-nightly.yaml#L7-L8Why is this needed?
Gain greater confidence and samples of e2e tests running against
arm64cpu architecture.Hopefully detect issues before pull requests are merged to
main.The text was updated successfully, but these errors were encountered: