Skip to content

Commit

Permalink
cmd: move "cmd/vendor" to root, remove "cmd"
Browse files Browse the repository at this point in the history
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
  • Loading branch information
gyuho committed Jan 24, 2018
1 parent fa9f3dd commit b1e87f8
Show file tree
Hide file tree
Showing 829 changed files with 0 additions and 7 deletions.
4 changes: 0 additions & 4 deletions cmd/README.md

This file was deleted.

1 change: 0 additions & 1 deletion cmd/etcd

This file was deleted.

1 change: 0 additions & 1 deletion cmd/etcdctl

This file was deleted.

1 change: 0 additions & 1 deletion cmd/tools

This file was deleted.

File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Loading

6 comments on commit b1e87f8

@daotang
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this change? A side effect of this vendoring in library instead of cmd cause this kind of panic:
Feb 13 16:36:53 host-10-10-2-163 apollo: panic: http: multiple registrations for /debug/requests
Feb 13 16:36:53 host-10-10-2-163 apollo: goroutine 1 [running]:
Feb 13 16:36:53 host-10-10-2-163 apollo: net/http.(*ServeMux).Handle(0x1360d40, 0xd01050, 0xf, 0x1315060, 0xd2a170)
Feb 13 16:36:53 host-10-10-2-163 apollo: /usr/local/go/src/net/http/server.go:2270 +0x627
Feb 13 16:36:53 host-10-10-2-163 apollo: net/http.(*ServeMux).HandleFunc(0x1360d40, 0xd01050, 0xf, 0xd2a170)
Feb 13 16:36:53 host-10-10-2-163 apollo: /usr/local/go/src/net/http/server.go:2302 +0x55
Feb 13 16:36:53 host-10-10-2-163 apollo: net/http.HandleFunc(0xd01050, 0xf, 0xd2a170)
Feb 13 16:36:53 host-10-10-2-163 apollo: /usr/local/go/src/net/http/server.go:2314 +0x4b
Feb 13 16:36:53 host-10-10-2-163 apollo: golang.org/x/net/trace.init.0()
Feb 13 16:36:53 host-10-10-2-163 apollo: /home/zen/go/src/golang.org/x/net/trace/trace.go:115 +0x42
Feb 13 16:36:53 host-10-10-2-163 apollo: golang.org/x/net/trace.init()

@gyuho
Copy link
Contributor Author

@gyuho gyuho commented on b1e87f8 Feb 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daotang Can you open a new issue with reproducible steps?

@daotang
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gyuho, thanks
I have a go application which imports both etcdclientv3 and grpc, it panics with the above trace right after starting.

@gyuho
Copy link
Contributor Author

@gyuho gyuho commented on b1e87f8 Feb 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daotang etcd still uses gRPC 1.7. Are you using different versions of gRPC?

@daotang
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gyuho I doubt it's gRPC version issue. The panic is from golang.org/x/net/trace.init() which are called twice, one is from etcdclientv3, the other is from gRPC. The second time it's called it panics due to panic: http: multiple registrations for /debug/requests

@gyuho
Copy link
Contributor Author

@gyuho gyuho commented on b1e87f8 Feb 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daotang Please open a new issue with reproducible steps. And gRPC also uses trace package.

Please sign in to comment.