Skip to content

Commit

Permalink
Merge pull request #5861 from xiang90/fix_watch
Browse files Browse the repository at this point in the history
v3rpc: do not panic on user error for watch
  • Loading branch information
xiang90 authored Jul 3, 2016
2 parents 7cc4596 + 13a4056 commit 70bf768
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions etcdserver/api/v3rpc/watch.go
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,11 @@ func (sws *serverWatchStream) recvLoop() error {
sws.mu.Unlock()
}
}
// TODO: do we need to return error back to client?
default:
panic("not implemented")
// we probably should not shutdown the entire stream when
// receive an valid command.
// so just do nothing instead.
continue
}
}
}
Expand Down

0 comments on commit 70bf768

Please sign in to comment.