Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback alloc map: remove all page ids which are allocated by the txid #819

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Aug 12, 2024

Fix #797

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@tjungblu
Copy link
Contributor

/lgtm

thanks @ahrtr

@ahrtr
Copy link
Member Author

ahrtr commented Aug 19, 2024

cc @fuweid to take a look

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit e6b4ed7 into etcd-io:main Aug 19, 2024
18 checks passed
@ahrtr ahrtr deleted the rollback_alloc_20240812 branch August 19, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

The freelist.allocs isn't rollbacked when a tx is rollbacked
4 participants